abollini commented on PR #425: URL: https://github.com/apache/commons-configuration/pull/425#issuecomment-2133052890
hi @kbarlowgw , thanks for your feedback. If I understood correctly I should have added a test related to the wrong behavior introduced dealing with unset property https://github.com/apache/commons-configuration/pull/425/commits/e0edce6f3676081d8efe3c2adf446025452bcf74 Indeed, running the test without further change I got the following exception similar to your ``` [ERROR] Errors: [ERROR] TestConfigurationPropertySource.testListValueInjection » UnsatisfiedDependency Error creating bean with name 'org.apache.commons.configuration2.spring.TestConfigurationPropertySource': Unsatisfied dependency expressed through field 'booleanNullValue'; nested exception is org.springframework.beans.TypeMismatchException: Failed to convert value of type 'java.lang.String' to required type 'boolean'; nested exception is java.lang.IllegalArgumentException: Invalid boolean value [] [ERROR] TestConfigurationPropertySource.testNullValueInjection » UnsatisfiedDependency Error creating bean with name 'org.apache.commons.configuration2.spring.TestConfigurationPropertySource': Unsatisfied dependency expressed through field 'booleanNullValue'; nested exception is org.springframework.beans.TypeMismatchException: Failed to convert value of type 'java.lang.String' to required type 'boolean'; nested exception is java.lang.IllegalArgumentException: Invalid boolean value [] [ERROR] TestConfigurationPropertySource.testSystemPropertyValueInjection » UnsatisfiedDependency Error creating bean with name 'org.apache.commons.configuration2.spring.TestConfigurationPropertySource': Unsatisfied dependency expressed through field 'booleanNullValue'; nested exception is org.springframework.beans.TypeMismatchException: Failed to convert value of type 'java.lang.String' to required type 'boolean'; nested exception is java.lang.IllegalArgumentException: Invalid boolean value [] [ERROR] TestConfigurationPropertySource.testValueInjection » UnsatisfiedDependency Error creating bean with name 'org.apache.commons.configuration2.spring.TestConfigurationPropertySource': Unsatisfied dependency expressed through field 'booleanNullValue'; nested exception is org.springframework.beans.TypeMismatchException: Failed to convert value of type 'java.lang.String' to required type 'boolean'; nested exception is java.lang.IllegalArgumentException: Invalid boolean value [] [INFO] [ERROR] Tests run: 2942, Failures: 0, Errors: 4, Skipped: 2 ``` that are solved with the commit https://github.com/apache/commons-configuration/pull/425/commits/ab388c3a0c97cd249dfc2945b149da8b34e01da6 I would appreciate a new check on your side. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
