thachlp commented on PR #630: URL: https://github.com/apache/commons-io/pull/630#issuecomment-2143385605
> @thachlp Thank you for your PR. The PR does not test all the new code, specifically HTTP (as opposed to HTTPS). Refactor duplicate method calls. You should check if a file system is installed already that handles HTTP[S] before overriding NIO Path handling; see `org.apache.commons.io.file.spi.FileSystemProviders`. TY! Hi @garydgregory, thanks for your review. Base on the test `testGetFileSystemProvider_all` on `FileSystemProvidersTest`, there is no scheme `http` and `https`. Do I miss something? Please help review again 🙇 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
