kbarlowgw commented on PR #431:
URL:
https://github.com/apache/commons-configuration/pull/431#issuecomment-2145804710
Sounds good to me. I've run it through our code and see no issues.
On Mon, Jun 3, 2024 at 1:30 PM Tim Donohue ***@***.***> wrote:
> ***@***.**** commented on this pull request.
>
> 👍 For my purposes, this looks correct. There's only a single behavior
> change in this code which ensure commons-configuration v2.10.x is again
> "backwards compatible" with v2.9.0.
>
> Essentially, in 2.9.0, if you had an empty string property (e.g.
my.property
> = ) this was seen as an empty string ("") in Spring Boot. However, if the
> property was unspecified, this was seen as null in Spring Boot.
>
> The code in this PR looks correct to me as it now correctly differentiates
> an unspecified property from an empty string property.
>
> —
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/commons-configuration/pull/431#pullrequestreview-2094484285>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/BBG2EVFOXBQGQOTVZOBFUN3ZFSR2RAVCNFSM6AAAAABITQCBIOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAOJUGQ4DIMRYGU>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
