[ 
https://issues.apache.org/jira/browse/LANG-1196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17860048#comment-17860048
 ] 

M. Justin commented on LANG-1196:
---------------------------------

[~ggregory] I would say this isn't at all fixed, since the requested ability to 
specify the random number source (for repeatable testing) is very much not 
fulfilled by the changes made.  Instead of a {{Random}} that can't be replaced, 
there's instead a {{ThreadLocalRandom}} that can't be replaced.

It might be that it doesn't make sense to change the class in the requested 
manner, but that would be more of a "Won't Fix" and not a "Fixed", right?

> Provide way to set random number generator on RandomStringUtils to enable 
> repeatable test execution
> ---------------------------------------------------------------------------------------------------
>
>                 Key: LANG-1196
>                 URL: https://issues.apache.org/jira/browse/LANG-1196
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>    Affects Versions: 3.4
>         Environment: java version "1.8.0_66"
> Java(TM) SE Runtime Environment (build 1.8.0_66-b17)
> Java HotSpot(TM) 64-Bit Server VM (build 25.66-b17, mixed mode)
> Linux 4.0.5 #3 SMP Mon Sep 14 12:41:09 BST 2015 x86_64 Intel(R) Core(TM) 
> i7-4710MQ CPU @ 2.50GHz GenuineIntel GNU/Linux
>            Reporter: Gus Power
>            Priority: Minor
>             Fix For: 3.13.0
>
>         Attachments: LANG-1196.patch
>
>
> Hi,
> I'm using [Sham 
> |http://search.maven.org/#artifactdetails%7Corg.shamdata%7Csham%7C0.3%7Cjar] 
> to generate realistic looking test data for both parameterized tests and user 
> acceptance testing. We log the seed that is used for each run so that if 
> there is an issue we can recreate exactly the same test data. I would also 
> like to use some of the commons-lang RandomStringUtils functionality but 
> notice that the implementation provides no way of setting the random number 
> generator to be used.
> {code}private static final Random RANDOM = new Random();{code}
> A way to configure this would be really useful. If there is an alternative 
> way to do this then that would be great. If you think it's a good idea and it 
> requires a patch I'm happy to supply one.
> Cheers,
> Gus.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to