garydgregory commented on code in PR #513:
URL:
https://github.com/apache/commons-collections/pull/513#discussion_r1679208111
##########
pom.xml:
##########
@@ -491,6 +491,13 @@
<version>5.2.0</version>
<scope>test</scope>
</dependency>
+
+ <dependency>
Review Comment:
FIx indentation.
##########
pom.xml:
##########
@@ -741,16 +830,14 @@
</configuration>
</plugin>
<plugin>
+
<groupId>com.github.siom79.japicmp</groupId>
<artifactId>japicmp-maven-plugin</artifactId>
</plugin>
- <plugin>
- <groupId>com.github.spotbugs</groupId>
- <artifactId>spotbugs-maven-plugin</artifactId>
- </plugin>
+
<plugin>
<groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-pmd-plugin</artifactId>
+ <artifactId>maven-pmd-plugin</artifactId>
Review Comment:
Fix indentation.
##########
pom.xml:
##########
@@ -645,6 +659,27 @@
<resourceExcludes>NOTICE.txt,LICENSE.txt,**/pom.properties,**/test*.properties,**/resolver-status.properties</resourceExcludes>
</configuration>
</plugin>
+
+ <plugin>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-maven-plugin</artifactId>
+
+ <configuration>
+ <effort>Max</effort>
+ <threshold>medium</threshold>
+ <failOnError>true</failOnError>
+
<includeFilterFile>${basedir}/src/conf/spotbugs-include-filter.xml</includeFilterFile>
Review Comment:
We already have `src/conf/findbugs-exclude-filter.xml`.
##########
src/conf/spotbugs-exclude-filter.xml:
##########
@@ -0,0 +1,26 @@
+<?xml version="1.0"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+<!--
+ This file contains some false positive bugs detected by findbugs. Their
+ false positive nature has been analyzed individually, and they have been
+ put here to instruct findbugs it must ignore them.
+-->
Review Comment:
We already have `src/conf/findbugs-exclude-filter.xml`.
##########
pom.xml:
##########
@@ -673,6 +709,59 @@
</archive>
</configuration>
</plugin>
+
+ <plugin>
+ <groupId>org.jacoco</groupId>
+ <artifactId>jacoco-maven-plugin</artifactId>
+ <version>0.8.11</version> <!-- Use the latest version available -->
Review Comment:
jacoco-maven-plugin is defined in the parent POM. If you want to update the
version, there is a property for that.
##########
pom.xml:
##########
@@ -515,6 +522,13 @@
<version>33.0.0-jre</version>
<scope>test</scope>
</dependency>
+
+ <dependency>
Review Comment:
Not needed, this comes in from the parent POM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
