[ 
https://issues.apache.org/jira/browse/CLI-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12881328#action_12881328
 ] 

Emmanuel Bourg commented on CLI-193:
------------------------------------

I believe the absolute rule for the wrapping should be to not exceed the 
maximum width, then to do the best effort to wrap on space characters, and if 
it is not possible, break a word.

> StringIndexOutOfBoundsException in HelpFormatter.findWrapPos
> ------------------------------------------------------------
>
>                 Key: CLI-193
>                 URL: https://issues.apache.org/jira/browse/CLI-193
>             Project: Commons CLI
>          Issue Type: Bug
>          Components: CLI-1.x
>    Affects Versions: 1.2
>            Reporter: Travis McLeskey
>            Priority: Critical
>             Fix For: 1.3
>
>         Attachments: cli-helpformatter-stringIndexOOB-2.patch, 
> cli-helpformatter-stringIndexOOB.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> In the last while loop in HelpFormatter.findWrapPos, it can pass 
> text.length() to text.charAt(int), which throws a 
> StringIndexOutOfBoundsException. The first expression in that while loop 
> condition should use a <, not a <=.
> This is on line 908 in r779646:
>   
> http://svn.apache.org/viewvc/commons/proper/cli/trunk/src/java/org/apache/commons/cli/HelpFormatter.java?revision=779646&view=markup

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to