johnou commented on PR #411: URL: https://github.com/apache/commons-dbcp/pull/411#issuecomment-2271262650
Hi @garydgregory It allows the developer to override / have the final say on whether or not a connection is disconnected after the existing checks are done, the behaviour is in line with how Hikari handles exceptions [1] so developers migrating to / from these libraries won't run into any unexpected behaviour. Using this interface gives developers more flexibility, especially for vendor-specific logic. In my case 08S02 and 08007 should not be considered fatal when using Aurora, I don't have a list of known errors we should disconnect on and this approach seemed a lot more versatile vs adding a new list of error codes to ignore. iirc there is another use case for postgres with regards to timeout exceptions. Thanks! [1] https://github.com/brettwooldridge/HikariCP/blob/dev/src/main/java/com/zaxxer/hikari/pool/ProxyConnection.java#L163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
