danielthegray commented on PR #1250:
URL: https://github.com/apache/commons-lang/pull/1250#issuecomment-2275506597

   FYI @garydgregory , this API change can cause issues in production code 
where the process will block waiting for more entropy. This is a huge deal!!
   
   I understand that there is a vulnerability where a password reset URL token 
was generated using RandomStringUtils and therefore the insecure random number 
generator. The solution can NOT be to just change the behavior for ALL random 
numbers to use the secure one! This is a very foundational library, used by 
many many applications for many many purposes, and just changing it its 
behavior so deeply (and in a way that **can cause hangs in production code**) 
is **UNACCEPTABLE**.
   
   So now, to fix the breaks and hangs that people have been complaining about, 
your solution is to persist in your API-behavior-breaking state and just add a 
new `.insecure()` that preserves the old behavior? This is not a workable 
solution, and I'll show you how: imagine that your application depends on 
Apache Commons Lang, as well as your dependency (which is generating the random 
strings). You can change your code to use `.insecure()` and then upgrade, but 
the library is still calling the old API (without `.insecure()`) and your 
upgrade will preserve the break.
   
   In short, I am asking the Apache Commons team to please revert the behavior 
to the previous non-hanging state. The solution to people choosing the wrong 
random number generator for things is not to force secure random number 
generators on everyone for every use-case!
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to