garydgregory commented on code in PR #421:
URL: https://github.com/apache/commons-dbcp/pull/421#discussion_r1721638831
##########
src/main/java/org/apache/commons/dbcp2/PoolableConnection.java:
##########
@@ -109,13 +116,37 @@ public PoolableConnection(final Connection conn, final
ObjectPool<PoolableConnec
* true means fatal disconnection errors cause subsequent
validations to fail immediately (no attempt to
* run query or isValid)
*/
+ public PoolableConnection(final Connection conn, final
ObjectPool<PoolableConnection> pool,
+ final ObjectName jmxObjectName, final
Collection<String> disconnectSqlCodes,
+ final boolean fastFailValidation) {
+ this(conn, pool, jmxObjectName, disconnectSqlCodes, null,
fastFailValidation);
+ }
+
+ /**
+ *
Review Comment:
This method is missing a Javadoc descriptive sentence.
##########
src/main/java/org/apache/commons/dbcp2/BasicDataSource.java:
##########
@@ -864,6 +871,22 @@ public Set<String> getDisconnectionSqlCodes() {
return result == null ? Collections.emptySet() : result;
}
+ /**
+ * Gets the set of SQL_STATE codes that are not considered fatal
disconnection codes.
Review Comment:
Please replace "SQL_STATE" with "SQL State", the current wording git master
uses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
