[ 
https://issues.apache.org/jira/browse/LANG-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881337#comment-17881337
 ] 

Gary D. Gregory commented on LANG-1752:
---------------------------------------

Hello [~SaifAsif]

I'm not sure this is the best approach IMO because there is more than one 
dimension to the APIs than case-sensitivity. My thinking here is to create a 
"Strings" class with defaults for:
- case-sensitivity
- Locale
- Charset

A default instance would be used like:
{code:java}
Strings.DEFAULT.startWith(...)
{code}
and
{code:java}
public static final Strings.MY_UTILS = 
Strings.builder().setCaseSenstivity(false).build();
MY_UTILS.startWith(...)
{code}

FYI, this has come up before: 
https://lists.apache.org/thread/fb5myt33lprq464wyp98ox5mt2f9ghpm


> Seperating ignoresCase APIs from StringUtils
> --------------------------------------------
>
>                 Key: LANG-1752
>                 URL: https://issues.apache.org/jira/browse/LANG-1752
>             Project: Commons Lang
>          Issue Type: Improvement
>    Affects Versions: 4.0
>            Reporter: Saif Asif
>            Priority: Major
>
> Overtime, more and more APIs are being added to the StringUtils class that 
> are a variation of existing APIs based on casing e.g `endsWithIgnoreCase` is 
> just `endsWith` with an additional boolean ignoreCase set to true.
> {code:java}
> public static boolean endsWithIgnoreCase(final CharSequence str, final 
> CharSequence suffix) {
>     return endsWith(str, suffix, true);
> }
> private static boolean endsWith(final CharSequence str, final CharSequence 
> suffix, final boolean ignoreCase) {}{code}
>  
> This leads to StringUtils class increasing in size.
> I would like to propose that we refactor StringUtils class and move all 
> ignoreCase APIs to their own class e.g something like 
> {code:java}
> StringUtilsIgnoreCase{code}
>  or so.
> Since the refactoring will be huge, we can target for the next major version 
> (4.0?) and introduce `@deprecated` on the methods to give users enough time 
> to track and update their existing code bases.
> What does the community think ?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to