ppkarwasz commented on PR #473: URL: https://github.com/apache/commons-csv/pull/473#issuecomment-2348176362
> @ppkarwasz The ExtendedBufferedReader calls reset() and mark() methods, we cannot remove the calls. I think it is not possible to extend the ExtendedBufferedReader from Reader, the implementations for reset() and mark() are missing. Or I missunderstand your proposal. No, you didn't misunderstand. Effectively, looking at the code, the task is larger than I expected, so you'll need to add some methods to `ExtendedBufferedReader` if you refactor it as direct derivative class of `Reader`. Please, provide a **minimal** implementation: if `Lexer` does not need a method, don't implement it, because it will be dead code. In your current approach you copied and refactored the entire `BufferedReader` class. `Lexer` does not need all of that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
