[ 
https://issues.apache.org/jira/browse/NET-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887205#action_12887205
 ] 

Sebb commented on NET-180:
--------------------------

Agreed option 2 is best.

One minor issue is that the TelnetNotificationHandler would need a new 
"negociation" code - e.g. RECEIVED_COMMAND - which might possibly cause 
problems for code that only checks for DO/DONT/WILL/WONT as per the Javadoc. 
Also IAC commands are not really negociations.

But I doubt it is worth worrying about that - the Javadoc does not explicitly 
say that there won't be other codes added in future.

> Telnet EOR is "consumed" by TelnetInputStream when in BINARY transmission
> -------------------------------------------------------------------------
>
>                 Key: NET-180
>                 URL: https://issues.apache.org/jira/browse/NET-180
>             Project: Commons Net
>          Issue Type: Bug
>          Components: Telnet
>    Affects Versions: 1.4
>         Environment: Applies to all platforms
>            Reporter: Chris Jones
>
> I have a TN5250 client (see rfc1205) which extends TelnetClient. Basically, 
> the client negotiates BINARY transmission and operates in block-mode. However 
> the host sends IAC EOR at the end of each block in order to notify the client 
> that the transmission of the block of data is complete, and the client should 
> build the display. The problem is that the IAC EOR is "consumed" by the 
> TelnetInputStream and therefore never reaches the client.
> There are a few ways this could be handled, here are couple of suggestions 
> (the 2nd is probably better):-
> 1. Within TelnetInputStream, treat IAC EOR as data when in BINARY 
> transmission state
> 2. Extend TelnetNotificationHandler and send notifications of all Telnet 
> Commands received

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to