garydgregory commented on PR #339: URL: https://github.com/apache/commons-pool/pull/339#issuecomment-2419344389
Hello all and @psteitz My view here is twofold: - No unit tests: Without a unit test that fails if the changes to main are not applied, this is just an invitation for a regression, or new bugs. What I don't know is if you can use a multi release source folder with tests or if its only supported for main. That would solve the issue of wanting a test that uses a post Java 8 API. - Inconsistent use of locks. It would be best if the whole library used the same style of locking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
