[ 
https://issues.apache.org/jira/browse/COLLECTIONS-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893135#comment-17893135
 ] 

Gary D. Gregory commented on COLLECTIONS-809:
---------------------------------------------

I think these tests reveal a potential underlying issue: The tests seem to just 
reflect the current state of the code which appears to use a mixed exception 
model. The good news is that we have tests, the bad news is that the 
implementing classes look confused to me.

I might be worth looking into what the API specification suggests or requires 
of these throwing APIs. If the underlying code is supposed to use one kind of 
exception, then that might be what needs fixing. Then the test can just assert 
for the one exception type instead of the current approach.


> Update try/catch/fail logic to assertThrows
> -------------------------------------------
>
>                 Key: COLLECTIONS-809
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-809
>             Project: Commons Collections
>          Issue Type: Sub-task
>            Reporter: John Patrick
>            Priority: Major
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to