kinow commented on PR #621: URL: https://github.com/apache/commons-text/pull/621#issuecomment-2440039166
> Please don't use assert-j ;-) it's not as clean as junit (assert-j makes a mess of trying to do assertEquals for example). I hadn't seen that that was used in the test. IDE failed to compile, and then I simply rewrote that as normal JUnit + assertThrows. Not sure why that had been used before, but it's removed. Will send a few separated commits addressing different feedback, will wait for new feedback (if I manage to get it to some alright state), and squash or drop commits as needed :+1: Feel free to commit anything here if you'd like, at any time :+1: Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
