garydgregory commented on PR #602: URL: https://github.com/apache/commons-compress/pull/602#issuecomment-2462315000
> > I like the simplification 😄 but, what about [COMPRESS-638](https://issues.apache.org/jira/browse/COMPRESS-638)? > > Do we just say, use `GzipParameters.setFileNameCharset(Charset)` and adjust the tests to pass? > > We could validate `GzipParameters` in the constructor of `GzipCompressorOutputStream` and throw if the filename can not be encoded. That would blow up existing call sites though. I think we want to keep RFC behavior by default. We now provide a non-RFC override for the next release. How about (maybe) : The next release provides this new non-RFC feature. Apps can then adapt to it. The default behavior is the same. For the release after that we can discuss changing the default behavior to no-longer % encode as a backstop, and adjust the tests. Or is that slicing it too thin? I'm concerned that adding another option now is too confusing. Not sure though. I'm not sure there is value in having an option to not use FNAME. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
