garydgregory commented on code in PR #340: URL: https://github.com/apache/commons-cli/pull/340#discussion_r1863489835
########## src/main/java/org/apache/commons/cli/processor/ArgumentProcessor.java: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.commons.cli.processor; + + +import org.apache.commons.cli.Option; + +public class ArgumentProcessor { Review Comment: This is not good: - This increases the public API footprint for no reason, increasing maintenance costs. - The code is just moved here and used from a single call-site. - As an aside, this is also a new public class without a class-level Javadoc. ########## src/main/java/org/apache/commons/cli/config/HelpFormatterConfig.java: ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.commons.cli.config; + +import org.apache.commons.cli.Option; + +import java.io.PrintWriter; +import java.util.Objects; +import java.util.function.Function; + +public class HelpFormatterConfig { Review Comment: Same comment as for the new `ArgumentProcessor`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org