ppkarwasz commented on PR #1322:
URL: https://github.com/apache/commons-lang/pull/1322#issuecomment-2508895463
> > JVM will never have PID 1
>
> JVM can certainly be PID 1 inside a container. Example:
Point taken.
> > checking `/proc/1/environ` and the environment of the JVM is equivalent.
>
> Yes, equivalent but perhaps reading from `System.getenv()` is a slight
improvement by avoiding file i/o on procfs
Your code requires the `java.management` Java module to handle a specific
case that was already handled correctly by the previous code (which only
requires `java.base`). IMHO this is not an improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
