Serwios opened a new pull request, #1333:
URL: https://github.com/apache/commons-lang/pull/1333

   Created factory to throw common math exception as there was too much message 
duplication, simplified already created messages. (Maybe make sense to create 
custom math exception to separate it from type validations, and nan checks etc)
   
   - [X] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
   - [X] Run a successful build using the default 
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command 
line by itself.
   - [X] Write unit tests that match behavioral changes, where the tests fail 
if the changes to the runtime are not applied. This may not always be possible 
but is a best-practice.
   - [X] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [X] Each commit in the pull request should have a meaningful subject line 
and body. Note that commits might be squashed by a maintainer on merge.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to