Serwios commented on PR #1332: URL: https://github.com/apache/commons-lang/pull/1332#issuecomment-2542096948
> @Serwios, > > String concatenation is IMHO more readable than the equivalent `StringBuilder` construction, but changing this in a single method that is probably not used and certainly not tested, doesn't make sense to me. > > Could you go the extra mile of: > > * proposing on the `[email protected]` mailing list to replace simple `StringBuilder` constructs with string concatenation. Whether to use `StringBuilder`, string concatenation or `String.format()` is mostly a matter of taste and IDEs can refactor each one of these formats into another. > * if the community accepts the change, apply it **everywhere**? I’ll propose this discussion on the [email protected] mailing list to determine if there’s a preference within the team for standardizing string concatenation over StringBuilder or other alternatives like String.format(). If the community supports this, I’m happy to take the lead on refactoring similar cases project-wide to ensure consistency. IMHO: Regarding standardization, I believe it’s about establishing a common pattern that promotes code readability and maintainability. Having a generally accepted approach ensures that contributors don’t waste time debating minor stylistic differences and instead focus on improving functionality. It also makes the codebase easier to review, debug, and extend, especially for new contributors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
