garydgregory commented on PR #1337: URL: https://github.com/apache/commons-lang/pull/1337#issuecomment-2542595995
Hello @Serwios -1: - You checked the box "Run a successful build using the default [Maven](https://maven.apache.org/) goal with mvn; that's mvn on the command line by itself." but you obviously didn't do it since the build fails for me locally: ``` [ERROR] Failures: [ERROR] StringsTest.testRemoveAccents:141 expected: <Cafe> but was: <Caf?> ``` Checkstyle also fails: ``` [ERROR] src\main\java\org\apache\commons\lang3\Strings.java:[25,1] (imports) ImportOrder: Wrong order for 'java.text.Normalizer' import. [ERROR] src\main\java\org\apache\commons\lang3\Strings.java:[28,8] (imports) UnusedImports: Unused import - java.util.stream.Collectors. [ERROR] src\test\java\org\apache\commons\lang3\StringsTest.java:[26,1] (imports) ImportOrder: Wrong order for 'org.junit.jupiter.api.Assertions.*' import. [ERROR] src\test\java\org\apache\commons\lang3\StringsTest.java:[26,47] (imports) AvoidStarImport: Using the '.*' form of import should be avoided - org.junit.jupiter.api.Assertions.*. ``` We've deprecated text processing functionality from Lang and moved it to Commons Text. For example, the whole `org.apache.commons.lang3.text` package is deprecated. - `truncateWithEllipsis()`: See the general note on text processing above. I'm not sure the function is useful as is anyway. Unicode supports the horizontal ellipsis character but this function doesn't use it? Why three periods instead? Should it be configurable, and so on. - `reverseWords`: See the general note on text processing above. - `containsOnly`: How is this different from StringUtils.indexOfAnyBut()? - `maskString`: See the general note on text processing above. In general, there are probably too many variations or use cases. Masking is usually much more complex, like "Replace phone numbers, credit cards, and so on, with X" - `removeAccents`: See the general note on text processing above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
