garydgregory commented on code in PR #462:
URL: https://github.com/apache/commons-dbcp/pull/462#discussion_r1884693306
##########
src/main/java/org/apache/commons/dbcp2/PoolingConnection.java:
##########
@@ -122,7 +121,6 @@ public synchronized void close() throws SQLException {
}
} finally {
try {
- @SuppressWarnings("resource")
Review Comment:
Do not remove `SuppressWarnings`. There are there for a reason: IDEs can be
configured to show warnings, this documents that a warning can be ignored and
shows when Closeable and AutoCloseable resources are intentionally left open.
##########
src/main/java/org/apache/commons/dbcp2/PoolingConnection.java:
##########
@@ -47,7 +46,7 @@ public class PoolingConnection extends
DelegatingConnection<Connection>
/**
* Statement types.
- *
+ * <p>
Review Comment:
You'll want to close HTML tags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
