[ 
https://issues.apache.org/jira/browse/VALIDATOR-497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906749#comment-17906749
 ] 

Gilles Sadowski commented on VALIDATOR-497:
-------------------------------------------

bq. A method called isValid discovering that an object is not valid is not an 
exceptional condition.

+1
As per usual (best?) practice, a method named "isSomething" should return a 
{{boolean}}.

Is that the case here?
>From the description, it seems that the proposal is about an additional method 
>that would _enforce_ validity:
{code}
public static void verify(String iban) {
  if (!isValid(iban)) {
    throw new IllegalArgumentException("Not a valid IBAN: " + iban);
  }
}
{code}


> Extends validation result of IBANValidator
> ------------------------------------------
>
>                 Key: VALIDATOR-497
>                 URL: https://issues.apache.org/jira/browse/VALIDATOR-497
>             Project: Commons Validator
>          Issue Type: New Feature
>            Reporter: Slawomir Jaranowski
>            Priority: Major
>             Fix For: 1.10.0
>
>
> Currently we have a method {{IBANValidator#isValid}} which return true or 
> false depends on validation result.
> But for false result we don't know a reason, which can be like unsupported 
> country, invalid pattern, invalid checksum and so on ...
> Proposition is to add next method which throw exception with more details 
> about reason of failed verification.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to