garydgregory commented on PR #629: URL: https://github.com/apache/commons-io/pull/629#issuecomment-2629086446
Hello @baezzys This all feels confusing because I don't think we follow strict behavior to match the names we use in methods and parameter names. For example, strictly speaking, on [Windows](https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file), "foo.txt" is a file _name_ but "c:dir\foo.txt" is not a file name, is a _path_ pointing to a _file_. Then you have _components_, including _drive volumes_ also know as _drive designator_, directory names, and so on. It's going to be delicate to change this code without breaking existing apps to provide bug fixes. So let's be careful. IMO, moving this along is going to need a pragmatic approach with unit tests checking all these variations. Just talking about tweaking some method in PR comments isn't going to work for me, you have to run the whole test suite to check for unintended effects. It's a valuable line of experimentation and I'm sure there's room for improvement. HTH -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
