Jyotprabhs commented on PR #737:
URL: https://github.com/apache/commons-io/pull/737#issuecomment-2783170856
Hi
I apologize for creating PRs last night… I was trying to learn stuff how it
moves in GitHub.
I will try to be more careful.
Thank you
Prabhjot Kaur
952-913-4231
On Mon, Apr 7, 2025 at 8:25 AM Gary Gregory ***@***.***>
wrote:
> ***@***.**** requested changes on this pull request.
>
> -1: Duplicate tests, build fails.
>
> Please stop creating PRs until you review your 2 other PRs where I
> commented with the same issues.
>
> By just looking at the first few methods, I can see this PR just
> duplicates existing tests in one or more of:
>
> - FilenameUtilsTest
> - FilenameUtilsWildcardTest
> - FileUtilsCleanDirectoryTest
> - FileUtilsCleanSymlinksTest
> - FileUtilsCopyDirectoryToDirectoryTest
> - FileUtilsCopyToFileTest
> - FileUtilsDeleteDirectoryLinuxTest
> - FileUtilsDeleteDirectoryWindowsTest
> - FileUtilsDirectoryContainsTest
> - FileUtilsFileNewerTest
> - FileUtilsListFilesTest
> - FileUtilsTest
> - FileUtilsWaitForTest
>
> Please be considerate and do not create duplicate tests, which wastes
> maintainers' time in reviews. Please analyze what we already have before
> asking maintainers to spend their time on your code.
>
> Was this code generated?
>
> Why do the new classes carry a "Pk" and "PK" postfix in their names? If
> the name is meaningful, you should call it out in a Javadoc comment. Note
> that by convention in this component, all test classes are postfixed with
> "Test" only.
>
> The PR does not have a description with your intended goal. Did you
> examine the JaCoCo code coverage report and find a branch or method not
> covered?
>
> If you let us know what you’re trying to do, this helps us help you if
> appropriate for the PR.
>
> You did not follow the steps in the PR template which causes the build to
> fail when I apply your patch locally, you must run mvn by itself to run
> all build checks:
>
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[30]
(regexp) Regexp: Line matches the illegal pattern 'Trailing whitespace'.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[32,37]
(whitespace) WhitespaceAround: '{' is not preceded with whitespace.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[33,14]
(coding) FinalLocalVariable: Variable 'file' should be declared final.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[33,19]
(whitespace) WhitespaceAround: '=' is not followed by whitespace.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[34,17]
(coding) FinalLocalVariable: Variable 'result' should be declared final.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[37]
(regexp) Regexp: Line matches the illegal pattern 'Trailing whitespace'.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[40,49]
(whitespace) WhitespaceAround: '{' is not preceded with whitespace.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[41,14]
(coding) FinalLocalVariable: Variable 'file' should be declared final.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[42,17]
(coding) FinalLocalVariable: Variable 'result' should be declared final.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[45]
(regexp) Regexp: Line matches the illegal pattern 'Trailing whitespace'.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[46]
(regexp) Regexp: Line matches the illegal pattern 'Trailing whitespace'.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[49,66]
(whitespace) WhitespaceAround: '{' is not preceded with whitespace.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[50,14]
(coding) FinalLocalVariable: Variable 'dir' should be declared final.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[50,17]
(whitespace) WhitespaceAround: '=' is not preceded with whitespace.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[51]
(regexp) Regexp: Line matches the illegal pattern 'Trailing whitespace'.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[52,20]
(whitespace) WhitespaceAfter: ';' is not followed by whitespace.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[53,17]
(coding) FinalLocalVariable: Variable 'result' should be declared final.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[56]
(regexp) Regexp: Line matches the illegal pattern 'Trailing whitespace'.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[57]
(regexp) Regexp: Line matches the illegal pattern 'Trailing whitespace'.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[60,69]
(whitespace) WhitespaceAround: '{' is not preceded with whitespace.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[61,14]
(coding) FinalLocalVariable: Variable 'dir' should be declared final.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[61,17]
(whitespace) WhitespaceAround: '=' is not preceded with whitespace.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[62]
(regexp) Regexp: Line matches the illegal pattern 'Trailing whitespace'.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[63,20]
(whitespace) WhitespaceAfter: ';' is not followed by whitespace.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[64,21]
(whitespace) WhitespaceAfter: ',' is not followed by whitespace.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[65,17]
(coding) FinalLocalVariable: Variable 'result' should be declared final.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[68]
(regexp) Regexp: Line matches the illegal pattern 'Trailing whitespace'.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[69]
(regexp) Regexp: Line matches the illegal pattern 'Trailing whitespace'.
> [ERROR] src/test/java/org/apache/commons/io/FileUtils_TestPK.java:[70]
(regexp) Regexp: Line matches the illegal pattern 'Trailing whitespace'.
> [ERROR]
src/test/java/org/apache/commons/io/FilenameUtils_TestPk.java:[30,17]
(whitespace) WhitespaceAround: '{' is not preceded with whitespace.
> [ERROR] src/test/java/org/apache/commons/io/FilenameUtils_TestPk.java:[33]
(regexp) Regexp: Line matches the illegal pattern 'Trailing whitespace'.
> [ERROR]
src/test/java/org/apache/commons/io/FilenameUtils_TestPk.java:[36,29]
(whitespace) WhitespaceAround: '{' is not preceded with whitespace.
> [ERROR]
src/test/java/org/apache/commons/io/FilenameUtils_TestPk.java:[38,16] (coding)
FinalLocalVariable: Variable 'baseName' should be declared final.
> [ERROR]
src/test/java/org/apache/commons/io/FilenameUtils_TestPk.java:[45,39]
(whitespace) WhitespaceAround: '{' is not preceded with whitespace.
> [ERROR]
src/test/java/org/apache/commons/io/FilenameUtils_TestPk.java:[47,16] (coding)
FinalLocalVariable: Variable 'baseName' should be declared final.
> [ERROR]
src/test/java/org/apache/commons/io/FilenameUtils_TestPk.java:[54,37]
(whitespace) WhitespaceAround: '{' is not preceded with whitespace.
> [ERROR]
src/test/java/org/apache/commons/io/FilenameUtils_TestPk.java:[56,16] (coding)
FinalLocalVariable: Variable 'baseName' should be declared final.
> [ERROR] src/test/java/org/apache/commons/io/FilenameUtils_TestPk.java:[59]
(regexp) Regexp: Line matches the illegal pattern 'Trailing whitespace'.
> [ERROR]
src/test/java/org/apache/commons/io/FilenameUtils_TestPk.java:[61,39]
(whitespace) WhitespaceAround: '{' is not preceded with whitespace.
> [ERROR]
src/test/java/org/apache/commons/io/FilenameUtils_TestPk.java:[63,16] (coding)
FinalLocalVariable: Variable 'baseName' should be declared final.
> [ERROR]
src/test/java/org/apache/commons/io/FilenameUtils_TestPk.java:[68,45]
(whitespace) WhitespaceAround: '{' is not preceded with whitespace.
> [ERROR]
src/test/java/org/apache/commons/io/FilenameUtils_TestPk.java:[70,16] (coding)
FinalLocalVariable: Variable 'baseName' should be declared final.
> [ERROR] src/test/java/org/apache/commons/io/FilenameUtils_TestPk.java:[73]
(regexp) Regexp: Line matches the illegal pattern 'Trailing whitespace'.
> [ERROR]
src/test/java/org/apache/commons/io/FilenameUtils_TestPk.java:[75,35]
(whitespace) WhitespaceAround: '{' is not preceded with whitespace.
> [ERROR]
src/test/java/org/apache/commons/io/FilenameUtils_TestPk.java:[77,16] (coding)
FinalLocalVariable: Variable 'baseName' should be declared final.
> [ERROR]
src/test/java/org/apache/commons/io/FilenameUtils_TestPk.java:[82,40]
(whitespace) WhitespaceAround: '{' is not preceded with whitespace.
> [ERROR]
src/test/java/org/apache/commons/io/FilenameUtils_TestPk.java:[84,16] (coding)
FinalLocalVariable: Variable 'baseName' should be declared final.
> [ERROR]
src/test/java/org/apache/commons/io/FilenameUtils_TestPk.java:[89,36]
(whitespace) WhitespaceAround: '{' is not preceded with whitespace.
> [ERROR]
src/test/java/org/apache/commons/io/FilenameUtils_TestPk.java:[91,16] (coding)
FinalLocalVariable: Variable 'baseName' should be declared final.
> [ERROR]
src/test/java/org/apache/commons/io/FilenameUtils_TestPk.java:[96,38]
(whitespace) WhitespaceAround: '{' is not preceded with whitespace.
> [ERROR]
src/test/java/org/apache/commons/io/FilenameUtils_TestPk.java:[98,16] (coding)
FinalLocalVariable: Variable 'baseName' should be declared final.
> [INFO]
------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
------------------------------------------------------------------------
> [INFO] Total time: 10.758 s
> [INFO] Finished at: 2025-04-07T08:18:22-04:00
> [INFO]
------------------------------------------------------------------------
>
> TY.
>
> —
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/commons-io/pull/737#pullrequestreview-2746634742>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AXK5RJVGOOBS5MMKONKMISL2YJVD5AVCNFSM6AAAAAB2STEPQGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDONBWGYZTINZUGI>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
