garydgregory commented on code in PR #1385:
URL: https://github.com/apache/commons-lang/pull/1385#discussion_r2094580261


##########
pom.xml:
##########
@@ -462,6 +463,32 @@
         <!-- LANG-1667: allow tests to access private fields/methods of 
java.base/java.util such as ArrayList via reflection -->
         <argLine>-Xmx512m --add-opens java.base/java.lang.reflect=ALL-UNNAMED 
--add-opens java.base/java.lang=ALL-UNNAMED --add-opens 
java.base/java.util=ALL-UNNAMED --add-opens java.base/java.time=ALL-UNNAMED 
--add-opens java.base/java.time.chrono=ALL-UNNAMED</argLine>
       </properties>
+      <build>
+        <plugins>
+          <!--
+            ~ Modifies the inherited Moditect configuration to add `java.sql` 
as `static` (optional) dependency.
+            -->
+          <plugin>
+            <groupId>org.moditect</groupId>
+            <artifactId>moditect-maven-plugin</artifactId>
+            <executions>
+              <execution>
+                <id>add-module-infos</id>
+                <configuration>
+                  <module>
+                    <moduleInfo>
+                      <requires>
+                        static java.sql;
+                        *;
+                      </requires>
+                    </moduleInfo>
+                  </module>
+                </configuration>
+              </execution>
+            </executions>
+          </plugin>

Review Comment:
   @ppkarwasz 
   Well, no, since we shouldn't depend on java[x].sql in the first place.
   
   All,
   Maybe this kind of this-to-that conversion code belongs in Commons BeanUtils.
   
   In Lang, DateUtils has only one kind of conversion ATM with 
'toCalendar'(...). I'm not sure we want to open the door to more convertions, 
then there would be endless combinations due to the scale of the Java Time 
package.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to