[ 
https://issues.apache.org/jira/browse/FILEUPLOAD-266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jochen Wiedmann resolved FILEUPLOAD-266.
----------------------------------------
    Resolution: Won't Fix

The simple fact, that javax.activation.DataSource is nowadays 
jakarta.activation.DataSource (or, in other words: The former is, at best, 
deprecated.) demonstrates, that we are better off leaving such issues to the 
fileupload user. If a DataSource is, what you need, then create one by wrapping 
a FileItem. 

> FileItem should extend javax.activation.DataSource (requires Java 1.6)
> ----------------------------------------------------------------------
>
>                 Key: FILEUPLOAD-266
>                 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-266
>             Project: Commons FileUpload
>          Issue Type: Improvement
>    Affects Versions: 1.3.1
>            Reporter: Eirik Lygre
>            Priority: Minor
>
> FileItem currently does not implement javax.activation.DataHandler; the 
> javadoc states "While this interface does not extend 
> javax.activation.DataSource per se (to avoid a seldom used dependency), 
> several of the defined methods are specifically defined with the same 
> signatures as methods in that interface. This allows an implementation of 
> this interface to also implement javax.activation.DataSource with minimal 
> additional work."
> This limitation stems from 2002 
> (http://svn.apache.org/viewvc/commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/FileItem.java?r1=133278&r2=133279&diff_format=h),
>  at a time when javax.activation.DataSource was not part of Java SE (Or J2SE, 
> which it was, back then!).
> Times have changed, and javax.activation.* have been part of Java SE proper 
> since Java 6. If/when java6 is an accepted minimum for FileUpload, FileItem 
> should extend javax.activation.DataSource.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to