brettkail-wk commented on code in PR #1355: URL: https://github.com/apache/commons-lang/pull/1355#discussion_r2207483735
########## src/main/java/org/apache/commons/lang3/ObjectUtils.java: ########## @@ -580,7 +580,7 @@ public static short CONST_SHORT(final int v) { * @param object the {@link Object} to test, may be {@code null} * @param defaultValue the default value to return, may be {@code null} * @return {@code object} if it is not {@code null}, defaultValue otherwise - * TODO Rename to getIfNull in 4.0 Review Comment: I'm not familiar with the history of the TODO. That said, I have a project with hundreds/thousands of `defaultIfNull`. It's unclear that `getIfNull` is better than `defaultIfNull`, or at least it's unclear that it's enough better to deprecate `defaultIfNull`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org