jajik commented on code in PR #271:
URL: https://github.com/apache/commons-daemon/pull/271#discussion_r2216442108
##########
.github/workflows/windows.yml:
##########
@@ -48,12 +48,15 @@ jobs:
- uses: actions/checkout@v4
with:
ref: master
- - name: Test JAVA_HOME
+ - name: Set JAVA_HOME and compiler/linker options
shell: cmd
run: |
- echo rem SPDX-License-Identifier: Apache-2.0> set_java_home.bat
- echo set JAVA_HOME=%JAVA_HOME_21_X64%>> set_java_home.bat
- call .\set_java_home.bat
+ echo rem SPDX-License-Identifier: Apache-2.0> set_build_env.bat
+ echo set JAVA_HOME=%JAVA_HOME_21_X64%>> set_build_env.bat
+ echo set EXTRA_LFLAGS="/NODEFAULTLIB:libucrt.lib
/DEFAULTLIB:ucrt.lib /HIGHENTROPYVA">> set_build_env.bat
+ echo set EXTRA_CFLAGS="/GS">> set_build_env.bat
+ echo set EXTRA_RCFLAGS="/nologo /d _WINNT /d WINVER=0x0A00 /d
_WIN32_WINNT=0x0A00">> set_build_env.bat
+ call .\set_build_env.bat
Review Comment:
Wouldn't a definition within `env` section work too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
