ppkarwasz commented on PR #1417: URL: https://github.com/apache/commons-lang/pull/1417#issuecomment-3094727523
@Naveenkumarsuk, Thank you for your contribution and for engaging constructively throughout the review process. While your intention to improve the documentation is appreciated, this PR introduced several regressions — including the removal of important nullability annotations, formatting inconsistencies, and the omission of the `@since` tag — which outweigh the benefits of the proposed changes. Additionally, the most recent commit 1ce9413e7c7e3583fbddec1722c29bf7d43f2724 unexpectedly modified the method implementation itself, which was not discussed or justified in the original scope of the PR. Given these concerns and the unclear overall value added by the changes, I’m closing this PR. We appreciate your effort, and we encourage future contributions — especially if they remain narrowly scoped, well-reviewed, and aligned with the project's established conventions. Thanks again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
