garydgregory commented on code in PR #272:
URL: https://github.com/apache/commons-daemon/pull/272#discussion_r2245152753
##########
.github/workflows/codeql-analysis.yml:
##########
@@ -13,13 +13,11 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-name: "CodeQL Java"
+name: "CodeQL"
on:
push:
- branches: [ master ]
pull_request:
- # The branches below must be a subset of the branches above
Review Comment:
Don't delete comments (unless they are wrong). Is this comment wrong? Some
one us don't know GH Actions inside out.
##########
.github/workflows/codeql-analysis.yml:
##########
@@ -39,7 +37,7 @@ jobs:
strategy:
fail-fast: false
matrix:
- language: [ 'java' ]
+ language: [ 'java', 'cpp' ]
Review Comment:
This seems to double up with the CPP specific file. Can you explain please?
##########
.github/workflows/codeql-analysis-cpp.yml:
##########
@@ -17,7 +17,6 @@ name: "CodeQL CPP"
on:
push:
- branches: [ master ]
Review Comment:
Why are push branches removed in several files?
In Commons IO for example
(https://github.com/apache/commons-io/blob/master/.github/workflows/codeql-analysis.yml),
we specify master and these actions run for pull requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
