fkjellberg commented on code in PR #690: URL: https://github.com/apache/commons-compress/pull/690#discussion_r2296174211
########## src/main/java/org/apache/commons/compress/archivers/lha/LhaArchiveEntry.java: ########## @@ -0,0 +1,216 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.commons.compress.archivers.lha; + +import java.time.ZoneOffset; +import java.util.Date; +import java.util.Optional; + +import org.apache.commons.compress.archivers.ArchiveEntry; + +/** + * Represents an entry in a LHA archive. + * + * @since 1.29 + */ +public class LhaArchiveEntry implements ArchiveEntry { + private String name; + private boolean directory; + private long size; + private Date lastModifiedDate; + private long compressedSize; + private String compressionMethod; + private int crcValue; + private Optional<Integer> osId = Optional.empty(); + private Optional<Integer> unixPermissionMode = Optional.empty(); + private Optional<Integer> unixUserId = Optional.empty(); + private Optional<Integer> unixGroupId = Optional.empty(); + private Optional<Integer> msdosFileAttributes = Optional.empty(); + private Optional<Integer> headerCrc = Optional.empty(); + + public LhaArchiveEntry() { + } + + @Override + public String toString() { + final StringBuffer sb = new StringBuffer().append("LhaArchiveEntry[") + .append("name=").append(name) + .append(",directory=").append(directory) + .append(",size=").append(size) + .append(",lastModifiedDate=").append(lastModifiedDate == null ? "" : lastModifiedDate.toInstant().atZone(ZoneOffset.UTC).toString()) + .append(",compressedSize=").append(compressedSize) + .append(",compressionMethod=").append(compressionMethod) + .append(",crcValue=").append(String.format("0x%04x", crcValue)); + + if (osId.isPresent()) { + sb.append(",osId=").append(osId.get()); + } + + if (unixPermissionMode.isPresent()) { + sb.append(",unixPermissionMode=").append(String.format("%03o", unixPermissionMode.get())); + } + + if (msdosFileAttributes.isPresent()) { + sb.append(",msdosFileAttributes=").append(String.format("%04x", msdosFileAttributes.get())); + } + + if (headerCrc.isPresent()) { + sb.append(",headerCrc=").append(String.format("0x%04x", headerCrc.get())); + } + + return sb.append("]").toString(); + } + + @Override + public String getName() { + return name; + } + + public void setName(String name) { + this.name = name; + } + + @Override + public long getSize() { + return size; + } + + public void setSize(long size) { + this.size = size; + } + + @Override + public Date getLastModifiedDate() { + return lastModifiedDate; + } + + public void setLastModifiedDate(Date lastModifiedDate) { + this.lastModifiedDate = lastModifiedDate; + } + + /** + * Returns the compressed size of this entry. + * + * @return the compressed size + */ + public long getCompressedSize() { + return compressedSize; + } + + public void setCompressedSize(long compressedSize) { + this.compressedSize = compressedSize; + } + + public void setDirectory(boolean directory) { + this.directory = directory; + } + + @Override + public boolean isDirectory() { + return directory; + } + + /** + * Returns the compression method of this entry. + * + * @return the compression method + */ + public String getCompressionMethod() { + return compressionMethod; + } + + public void setCompressionMethod(String compressionMethod) { + this.compressionMethod = compressionMethod; + } + + /** + * Returns the CRC-16 checksum of the uncompressed data of this entry. + * + * @return CRC-16 checksum of the uncompressed data + */ + public int getCrcValue() { + return crcValue; + } + + public void setCrcValue(int crc) { + this.crcValue = crc; + } + + /** + * Returns the operating system id if available for this entry. + * + * @return operating system id if available + */ + public Optional<Integer> getOsId() { + return osId; + } + + public void setOsId(Optional<Integer> osId) { + this.osId = osId; + } Review Comment: Understood. I changed them to return Integer instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
