jajik commented on code in PR #272:
URL: https://github.com/apache/commons-daemon/pull/272#discussion_r2303438211


##########
.github/workflows/codeql-analysis-cpp.yml:
##########
@@ -17,7 +17,6 @@ name: "CodeQL CPP"
 
 on:
   push:
-    branches: [ master ]

Review Comment:
   @ppkarwasz Could you please have a look at my latest comments? I believe 
there was a misunderstanding about the motivation behind removing the 
limitation.
   
   Also note, that the duplication with the feature branches can be handled by 
the `branches-ignore` I added for the depenabot.



##########
.github/workflows/codeql-analysis-cpp.yml:
##########
@@ -17,7 +17,6 @@ name: "CodeQL CPP"
 
 on:
   push:
-    branches: [ master ]

Review Comment:
   > (To be honest, dependabot has a lot of PRs too, but we can ignore its 
branches for the push trigger.)
   
   Added in 
https://github.com/apache/commons-daemon/pull/272/commits/5fab4e069f4cf904e49da51deb679482321ee2a6
 using `branches-ignore`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to