garydgregory commented on code in PR #699:
URL: https://github.com/apache/commons-compress/pull/699#discussion_r2303715286
##########
src/changes/changes.xml:
##########
@@ -58,7 +58,7 @@ The <action> type attribute can be add,update,fix,remove.
<action type="fix" dev="ggregory" due-to="Gary Gregory">Don't loose
precision while reading folders from a SevenZFile.</action>
<action type="fix" dev="ggregory" due-to="Roel van Dijk, Gary
Gregory">Improve some exception messages in TarUtils and
TarArchiveEntry.</action>
<!-- FIX bzip2 -->
- <action type="fix" dev="ggregory" due-to="Tyler Nighswander, Gary
Gregory">org.apache.commons.compress.compressors.bzip2.BZip2CompressorInputStream
constructors now throws CompressorException instead of
ArrayIndexOutOfBoundsException.</action>
+ <action type="fix" dev="pkarwasz" due-to="Tyler Nighswander, Piotr P.
Karwasz, Gary Gregory">Enforce 20-bit Huffman code-length limit consistently in
BZip2.</action>
Review Comment:
Hello @ppkarwasz
We lost some useful information in this edit. "Enforce" doesn't mean
anything unless you mention the consequence, which was previously included and
is still true after this PR:
"org.apache.commons.compress.compressors.bzip2.BZip2CompressorInputStream
constructors now throws CompressorException instead of
ArrayIndexOutOfBoundsException"
I would leave the original `action` and add a new one, something like:
"org.apache.commons.compress.compressors.bzip2.BZip2CompressorInputStream
constructors throw a CompressorException when input exceeds the 20-bit Huffman
code-length limit."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
