[
https://issues.apache.org/jira/browse/COMMONSSITE-178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Victoria Dimitrova updated COMMONSSITE-178:
-------------------------------------------
Description:
The method `DomainValidator.getInstance().isValid()` returns `true` for invalid
domain names that start or end with a hyphen when the domain name contains
Unicode characters.
This behavior is incorrect according to the domain name specifications (RFC
1035, RFC 5890), which do not allow:
- Domain labels starting or ending with a hyphen (`-`)
Test case that should pass but fails on version 1.10.0:
{code:java}
@Test
void shouldBeInvalid()
{
assertAll(() ->
assertFalse(DomainValidator.getInstance().isValid("-test.fr")),
() -> assertFalse(DomainValidator.getInstance().isValid("-tést.fr")),
() -> assertFalse(DomainValidator.getInstance().isValid("test-.fr")),
() -> assertFalse(DomainValidator.getInstance().isValid("tést-.fr")));
}
{code}
was:
The method `DomainValidator.getInstance().isValid()` returns `true` for invalid
domain names that start or end with a hyphen when the domain name contains
Unicode characters.
This behavior is incorrect according to the domain name specifications (RFC
1035, RFC 5890), which do not allow:
- Domain labels starting or ending with a hyphen (`-`)
Test case that should pass but fails on version 1.6:
{code:java}
@Test
void shouldBeInvalid()
{
assertAll(() ->
assertFalse(DomainValidator.getInstance().isValid("-test.fr")),
() -> assertFalse(DomainValidator.getInstance().isValid("-tést.fr")),
() -> assertFalse(DomainValidator.getInstance().isValid("test-.fr")),
() -> assertFalse(DomainValidator.getInstance().isValid("tést-.fr")));
}
{code}
> DomainValidator accepts hyphens at start/end of domain name with Unicode
> characters
> -----------------------------------------------------------------------------------
>
> Key: COMMONSSITE-178
> URL: https://issues.apache.org/jira/browse/COMMONSSITE-178
> Project: Apache Commons All
> Issue Type: Bug
> Reporter: Victoria Dimitrova
> Priority: Major
>
> The method `DomainValidator.getInstance().isValid()` returns `true` for
> invalid domain names that start or end with a hyphen when the domain name
> contains Unicode characters.
> This behavior is incorrect according to the domain name specifications (RFC
> 1035, RFC 5890), which do not allow:
> - Domain labels starting or ending with a hyphen (`-`)
> Test case that should pass but fails on version 1.10.0:
> {code:java}
> @Test
> void shouldBeInvalid()
> {
> assertAll(() ->
> assertFalse(DomainValidator.getInstance().isValid("-test.fr")),
> () -> assertFalse(DomainValidator.getInstance().isValid("-tést.fr")),
> () -> assertFalse(DomainValidator.getInstance().isValid("test-.fr")),
> () -> assertFalse(DomainValidator.getInstance().isValid("tést-.fr")));
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
