ppkarwasz commented on code in PR #1392:
URL: https://github.com/apache/commons-lang/pull/1392#discussion_r2358704339


##########
src/test/java/org/apache/commons/lang3/StringUtilsTest.java:
##########
@@ -3089,6 +3089,31 @@ void testTruncate_StringIntInt() {
         assertEquals("", StringUtils.truncate("abcdefghijklmno", 
Integer.MAX_VALUE, Integer.MAX_VALUE));
     }
 
+    @Test
+    void testTruncateToByteLength() {

Review Comment:
   The test suite in Commons IO is parameterized and takes into consideration 
the introduction of support for Unicode 15 in JDK 20 (grapheme clusters and so 
on): 
https://github.com/apache/commons-io/blob/b4ee32c53c0036429d64c0d6fe82a62a0fc6dae2/src/test/java/org/apache/commons/io/FileSystemTest.java#L171



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to