garydgregory commented on code in PR #396:
URL: https://github.com/apache/commons-cli/pull/396#discussion_r2364557928
##########
src/test/java/org/apache/commons/cli/TypeHandlerTest.java:
##########
@@ -177,7 +177,7 @@ void testCreateClass() throws ParseException {
@ParameterizedTest
@MethodSource("createDateFixtures")
void testCreateDate(final Date date) {
- assertEquals(date, TypeHandler.createDate(date.toString()));
+ assertEquals(date, TypeHandler.createDate(new SimpleDateFormat("EEE
MMM dd HH:mm:ss zzz yyyy").format(date)));
Review Comment:
@toxn
Please revert this change. It has nothing to do with the new feature.
If you want to introduce a change to how the tests are run, you can do so in
a different PR but this would not be the way to do it. If this is a locale
issue, you can use a JUnit Pioneer annotation on the method, please see git
master's change for this method:
```java
@DefaultLocale(language = "en", country = "US")
```
TY!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
