ppkarwasz commented on code in PR #784:
URL: https://github.com/apache/commons-io/pull/784#discussion_r2379044733


##########
src/test/java/org/apache/commons/io/build/CharSequenceOriginTest.java:
##########
@@ -62,13 +62,6 @@ void testGetFile() {
         assertThrows(UnsupportedOperationException.class, super::testGetFile);
     }
 
-    @Override
-    @Test
-    void testGetOutputStream() {

Review Comment:
   This helped me check whether each `✖` in the `AbstractOrigin` support matrix 
has a corresponding test, but you are right, I shouldn't have changed the order 
of the existing methods.
   
   Note that keeping alphabetical order is also not ideal as it separates 
related methods: I usually put the `static` method that generates parameters 
for a parameterized test near the test method. Reordering methods with Eclipse 
breaks them apart.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to