[ 
https://issues.apache.org/jira/browse/EXEC-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910502#action_12910502
 ] 

Siegfried Goeschl commented on EXEC-39:
---------------------------------------

Some thoughts along the line

+) What type of quoting is done/required when you invoke a shell script (bash, 
ksh) versus an application?!  
+) There are so many different scenarios and they are hard to test across 
multiple platforms
+) Looking at the comments I have the feeling that it is easy to break existing 
behavior used in real-life

That's the reason why I added "pre-quoted" arguments to avoid doing anything 
harmful and recommend building the command line incrementally instead or 
parsing a command line string. So I Iean towards "won't fix" otherwise I'm 
getting no release out of the door - any comments?



> StringUtils quoting problems
> ----------------------------
>
>                 Key: EXEC-39
>                 URL: https://issues.apache.org/jira/browse/EXEC-39
>             Project: Commons Exec
>          Issue Type: Bug
>    Affects Versions: 1.0
>            Reporter: Sebb
>            Assignee: Siegfried Goeschl
>             Fix For: 1.1
>
>
> There are various problems in the StringUtils class:
> isQuoted() - does not check that arguments have the same opening and closing 
> quotes. This may be a rare case, but it's trivial to fix. There are no test 
> cases for the method.
> quoteArgument()
>  - does not work properly on Windows, which only treats double-quote as a 
> quoting character; it should not fail if a Windows argument contains 
> single-quotes, as they are not special.
> - does not quote special Unix characters either
> stringSubstitution() does not document what the characters can constitute a 
> key.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to