iloveeclipse commented on code in PR #469:
URL: https://github.com/apache/commons-bcel/pull/469#discussion_r2394908489
##########
src/test/java/org/apache/bcel/classfile/ConstantPoolModuleAccessTest.java:
##########
@@ -161,7 +161,7 @@ public void visitModule(final Module obj) {
expected.add("java.time.chrono.AbstractChronology");
expected.add("java.time.chrono.Chronology");
expected.add("java.time.zone.ZoneRulesProvider");
- if (javaClass.getMajor() > Const.MAJOR_11) {
+ if (javaClass.getMajor() > Const.MAJOR_11 &&
javaClass.getMajor() < Const.MAJOR_24) {
Review Comment:
I simply open corresponding **module-info.class** files in Eclipse for
corresponding JDK and compare them. The test is NOT about packages! It checks
what is inside **module-info.class** **files**
Here diff I see for java.base from 21 vs 25
<img width="1859" height="1023" alt="image"
src="https://github.com/user-attachments/assets/35d607cc-8f76-493f-8076-b6640c3d8830";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
