[ 
https://issues.apache.org/jira/browse/BCEL-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18024019#comment-18024019
 ] 

Gary D. Gregory edited comment on BCEL-377 at 10/1/25 11:03 AM:
----------------------------------------------------------------

Hello [~iloveeclipse]

One item that remains is that some tests fail on Java 25. In our GitHub CI 
(https://github.com/apache/commons-bcel/actions), Java 25 and 26-ea are marked 
as experimental builds, so they appear as green builds. EA builds are always 
experimental. I think these tests also failed on Java 24.

For example, the current latest build: 
https://github.com/apache/commons-bcel/actions/runs/18048870529

It would speed things up if you could provide a PR on GitHub to address these 
Java 25 issues.

{noformat}
[ERROR] Failures: 
[ERROR]   ConstantPoolModuleAccessTest.testJREModules:370 expected: 
<[java.lang.System$LoggerFinder, java.net.ContentHandlerFactory, 
java.net.spi.InetAddressResolverProvider, 
java.net.spi.URLStreamHandlerProvider, 
java.nio.channels.spi.AsynchronousChannelProvider, 
java.nio.channels.spi.SelectorProvider, java.nio.charset.spi.CharsetProvider, 
java.nio.file.spi.FileSystemProvider, java.nio.file.spi.FileTypeDetector, 
java.security.Provider, java.text.spi.BreakIteratorProvider, 
java.text.spi.CollatorProvider, java.text.spi.DateFormatProvider, 
java.text.spi.DateFormatSymbolsProvider, 
java.text.spi.DecimalFormatSymbolsProvider, java.text.spi.NumberFormatProvider, 
java.time.chrono.AbstractChronology, java.time.chrono.Chronology, 
java.time.zone.ZoneRulesProvider, java.util.random.RandomGenerator, 
java.util.spi.CalendarDataProvider, java.util.spi.CalendarNameProvider, 
java.util.spi.CurrencyNameProvider, java.util.spi.LocaleNameProvider, 
java.util.spi.ResourceBundleControlProvider, 
java.util.spi.ResourceBundleProvider, java.util.spi.TimeZoneNameProvider, 
java.util.spi.ToolProvider, javax.security.auth.spi.LoginModule, 
jdk.internal.io.JdkConsoleProvider, jdk.internal.logger.DefaultLoggerFinder, 
sun.text.spi.JavaTimeDateTimePatternProvider, 
sun.util.locale.provider.LocaleDataMetaInfo, 
sun.util.resources.LocaleData$CommonResourceBundleProvider, 
sun.util.resources.LocaleData$SupplementaryResourceBundleProvider, 
sun.util.spi.CalendarProvider]> but was: <[java.lang.System$LoggerFinder, 
java.net.ContentHandlerFactory, java.net.spi.InetAddressResolverProvider, 
java.net.spi.URLStreamHandlerProvider, 
java.nio.channels.spi.AsynchronousChannelProvider, 
java.nio.channels.spi.SelectorProvider, java.nio.charset.spi.CharsetProvider, 
java.nio.file.spi.FileSystemProvider, java.nio.file.spi.FileTypeDetector, 
java.security.Provider, java.text.spi.BreakIteratorProvider, 
java.text.spi.CollatorProvider, java.text.spi.DateFormatProvider, 
java.text.spi.DateFormatSymbolsProvider, 
java.text.spi.DecimalFormatSymbolsProvider, java.text.spi.NumberFormatProvider, 
java.time.chrono.AbstractChronology, java.time.chrono.Chronology, 
java.time.zone.ZoneRulesProvider, java.util.spi.CalendarDataProvider, 
java.util.spi.CalendarNameProvider, java.util.spi.CurrencyNameProvider, 
java.util.spi.LocaleNameProvider, java.util.spi.ResourceBundleControlProvider, 
java.util.spi.ResourceBundleProvider, java.util.spi.TimeZoneNameProvider, 
java.util.spi.ToolProvider, javax.security.auth.spi.LoginModule, 
jdk.internal.io.JdkConsoleProvider, jdk.internal.logger.DefaultLoggerFinder, 
sun.text.spi.JavaTimeDateTimePatternProvider, 
sun.util.locale.provider.LocaleDataMetaInfo, 
sun.util.resources.LocaleData$CommonResourceBundleProvider, 
sun.util.resources.LocaleData$SupplementaryResourceBundleProvider, 
sun.util.spi.CalendarProvider]>
[ERROR]   ConstantPoolModuleAccessTest.testJREModules:370 expected: 
<[javax.annotation.processing.Processor, com.sun.source.util.Plugin, 
com.sun.tools.doclint.DocLint, com.sun.tools.javac.platform.PlatformProvider]> 
but was: <[javax.annotation.processing.Processor, com.sun.source.util.Plugin, 
com.sun.tools.doclint.DocLint, com.sun.tools.javac.platform.PlatformProvider, 
com.sun.tools.javac.api.JavacTrees$DocCommentTreeTransformer]>
[ERROR]   ConstantPoolModuleAccessTest.testJREModules:370 Found 
[com.sun.tools.javac.platform.PlatformProvider] in /jdk.jdeps/module-info.class 
==> expected: <0> but was: <1>
[ERROR]   BCELifierTest.testJavapCompare:197->testClassOnPath:161 expected: 
<Compiled from "Java8Example.java"
...
{noformat}





was (Author: garydgregory):
Hello [~iloveeclipse]

One item that remains is that some tests fail on Java 25. In our GitHub CI 
(https://github.com/apache/commons-bcel/actions), Java 25 and 26-ea are marked 
as experimental builds, so they appear as green builds. EA builds are always 
experimental. I think these tests also failed on Java 24.

For example, the current latest build: 
https://github.com/apache/commons-bcel/actions/runs/18048870529

It would speed things up if you could provide a PR on GitHub to address these 
Java 25 issues.



> Could you please release Java 25 compatible (patch) version ?
> -------------------------------------------------------------
>
>                 Key: BCEL-377
>                 URL: https://issues.apache.org/jira/browse/BCEL-377
>             Project: Commons BCEL
>          Issue Type: New Feature
>    Affects Versions: 6.10.0
>            Reporter: Dejan Stojadinović
>            Priority: Major
>              Labels: Java25, patch, patch-upgrade
>
> *Prologue:* [https://github.com/spotbugs/spotbugs/issues/3569] SpotBugs: 
> Update to BCEL stable 6.11 release
> *Note:* it really doesn't have to be a full-blown 6.11.0 release; patch 
> 6.10.1 would do:
>  * version 6.10.0: 
> [https://github.com/apache/commons-bcel/releases/tag/rel%2Fcommons-bcel-6.10.0]
>  and
>  * commit: 
> [https://github.com/apache/commons-bcel/commit/70562832ce2cc8925787bacf53911615e6fbb2b7]
> FYI [~ggregory] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to