garydgregory commented on PR #1459:
URL: https://github.com/apache/commons-lang/pull/1459#issuecomment-3369251870
Hello @jack5505
Here are a couple of comments and updates:
- Please rebase on git master.
- The `getIso3(String)` API in this PR is now redundant, you can now call:
- `LocaleUtils.toLocale("FR").getISO3Country()`, and
- `LocaleUtils.toLocale("FR").getDisplayCountry()`
- The existing API `LocaleUtils.toLocal(String)` has been updated to work
with 2-letter country codes without using any hard-coded tables.
- This test in this PR is wrong:
`assertEquals("United States of America",
CountryUtils.getCountryName("US"));` because `Locale.getDisplayCountry()` for
the US Locale returns `"United States"`, not `"United States of America"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
