ppkarwasz commented on PR #730: URL: https://github.com/apache/commons-compress/pull/730#issuecomment-3407133439
I’m inclined to remove this method unless there’s a compelling reason to keep it: https://github.com/apache/commons-compress/blob/0084a99a6fe9310099265df18f0eb5f1d980a26f/src/main/java/org/apache/commons/compress/compressors/snappy/SnappyCompressorInputStream.java#L185-L193 It was intended to replace `getSize()` inherited from `AbstractLZ77CompressorInputStream`, but the semantics are inconsistent across implementations: * `BlockLZ4CompressorInputStream#getSize()` returns the **number of uncompressed bytes read so far**. * `SnappyCompressorInputStream#getSize()` returns the **declared uncompressed size** from the stream metadata. Until we decide how the method should be used, we should probably restrict the visibility of the method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
