ppkarwasz opened a new pull request, #736: URL: https://github.com/apache/commons-compress/pull/736
This change deprecates `readFully` and `skip` in `o.a.c.compress.utils.IOUtils` in favor of their Commons IO counterparts. Beyond code reuse, this offers two benefits: * `readFully` had several overloads with inconsistent semantics. All read as many bytes as possible (like `read`), but only one threw on EOF (as `readFully` should). * `skip` previously used a per-call byte buffer, unlike the Commons IO version. Since apache/commons-io#801 upstreamed the concurrency fix, this workaround is no longer needed. **Note**: As `o.a.c.compress.utils.IOUtils` is now rarely used, it is always referenced by FQCN to avoid confusion. > [!CAUTION] > `readFully(InputStream, byte[])` and `readFully(InputStream, byte[], int, int)` exist in both `o.a.c.compress.utils.IOUtils` and `o.a.c.io.IOUtils` with identical signatures, so switching between them will **not show up** in diffs, even though their **behavior differs**. > > I verified that the Commons IO versions are used in only one `ZipFileTest` call site, and the choice there appears intentional. Nevertheless this is worth double checking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
