garydgregory commented on PR #1480: URL: https://github.com/apache/commons-lang/pull/1480#issuecomment-3480281271
-1: This PR will break existing applications. If I write an application today using `FastDateParser` on Java 8 through 25 that uses a short ID, it works. The short strings are deprecated on Java 25, not removed. It's up to the call site to decide when to migrate from using deprecated short IDs, not us to enforce it. This PR will cause these working applications to throw exceptions. This is not like a deprecated API we can stop using internally; it's more like users call a JRE public API in the form of IDs. This PR hides this break because it updates the tests to _avoid_ testing short IDs (on Java 25). It's a shame that the JRE writes to the console without a disablement option, but that's a different story. Rebase on git master to pick up the new test `FastDateParser_TimeZoneStrategyTest.testJava25DeprecatedZoneId(String)` which will break with this PR and make the point above hopefully more evident. What's odd, is that not all short IDs parse properly. See `testJava25DeprecatedZoneIds(final Map.Entry<String, String> entry)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
