IcoreE opened a new pull request, #1505: URL: https://github.com/apache/commons-lang/pull/1505
[LANG-1795](https://issues.apache.org/jira/browse/LANG-1795) EnumUtils.getEnumMap(...) currently collect enum values using Collectors.toMap(...) without a merge function.Because the default Collectors.toMap requires the key to be unique, these methods will throw an IllegalStateException if the provided keyFunction produces duplicate keys. ``` class EnumUtilsDuplicateKeyTest { enum Color { RED, ROSE } @Test void testGetEnumMapThrowsOnDuplicateKey() { assertThrows(IllegalStateException.class, () -> { EnumUtils.getEnumMap(Color.class, c -> c.name().substring(0, 1)); //Throw IllegalStateException }); } } ``` Proposed fix: Change the collection step to supply a merge function. A compatible, conservative default is to preserve the first-seen value Before you push a pull request, review this list: - [ ] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. - [ ] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
