centic9 commented on code in PR #732:
URL: https://github.com/apache/commons-text/pull/732#discussion_r2613187272
##########
src/test/java/org/apache/commons/text/lookup/DateStringLookupTest.java:
##########
@@ -42,9 +43,16 @@ void testBadFormat() {
@Test
void testDefault() throws ParseException {
- final String formatted = DateStringLookup.INSTANCE.apply(null);
- DateFormat.getInstance().parse(formatted); // throws ParseException
+ Locale prev = Locale.getDefault();
+ try {
+ // ensure that date-parser uses English/American presets
Review Comment:
The test fails for me locally when the OS is et to "de" instead of "us".
I don't see @DefaultLocale anywhere, do you have a link?
Anyway, reverted for now as it actually does not increase coverage, but just
fixes a local test failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
