sebbASF commented on PR #1522: URL: https://github.com/apache/commons-lang/pull/1522#issuecomment-3650673803
Thanks, but please don't mix multiple changes in a single PR, and don't introduce trailing spaces. The existing Javadoc is not consistent; not all versions say the string is returned unchanged if it is less than maxWidth. Also none of them say that the abbreviation marker length is only checked if abbreviation is necessary. Earlier checks can detect coding errors. So I'm not convinced that the code disagrees with the Javadoc. However it would be good to correct the inconsistencies, and clarify that the parameters are validated at the start. This also needs a test. I am also not convinced that the Exception messages need to be refactored, but in any case, that should be in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
