sebbASF commented on code in PR #665:
URL:
https://github.com/apache/commons-collections/pull/665#discussion_r2618912649
##########
src/main/java/org/apache/commons/collections4/MultiMapUtils.java:
##########
@@ -170,6 +171,27 @@ public static boolean isEmpty(final MultiValuedMap<?, ?>
map) {
return map == null || map.isEmpty();
}
+ /**
+ * A utility method to invert the mappings from a source MultiValuedMap
+ * to a collector MultiValuedMap. If you are trying to create an
+ * inverse multimap of the same kind as the original, consider using
+ * {@link MultiValuedMap#inverted()}.
+ *
+ * @param source take key-to-value mappings from here
+ * @param dest add value-to-key mappings here
+ * @param <K> the dest key type
+ * @param <V> the dest value type
+ * @param <M> the dest multimap
+ * @return the destination
Review Comment:
I think collector would be clearer here.
For the return comment, it could say 'the updated collector'
Also it would help to document the valid types for source and collector.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
