jher235 commented on PR #1532: URL: https://github.com/apache/commons-lang/pull/1532#issuecomment-3671248615
Hello @garydgregory, Sorry for the earlier misunderstanding — I initially thought that running the benchmarks locally and sharing the summary would be sufficient. I’ve now pushed the JMH benchmark source code (`src/test/java/.../StringUtilsJoinBenchmark.java`) to this PR as requested. Following the `StringUtilsGetDigitsBenchmark` example you mentioned, I expanded the benchmark scope. While my previous comments covered array sizes up to 1,000, I’ve added a 10,000-element case to the benchmark code as well. In this larger scenario, the execution time is slightly higher, while the allocation rate is still noticeably lower. This shows that the change does not provide a universal speedup, but it does consistently reduce memory allocation even at larger sizes. Thanks again for taking the time to review this in such detail — I really appreciate the guidance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
